corvus icon indicating copy to clipboard operation
corvus copied to clipboard

Make bind parameter take the actual interface, and port the port

Open tevino opened this issue 7 years ago • 8 comments

tevino avatar Mar 30 '17 02:03 tevino

@badboy corvus.conf should be changed as well, it's used for testing, thus the failure.

tevino avatar Mar 30 '17 06:03 tevino

Changed corvus.conf. Keep in mind this would be a breaking change in corvus and would affect all users. I grepped through the code to find all places of config.bind usage, but I might have missed some.

badboy avatar Mar 30 '17 10:03 badboy

In addition: this includes the minimal "get ipv6 working" patch. I did a manual test, but it would need to be tested more before getting merged.

badboy avatar Mar 30 '17 10:03 badboy

I fixed the test now, but it's now lacking any tests for the new bind option. I will add that later.

badboy avatar Mar 30 '17 10:03 badboy

For our production case, we get no benefits but rather extra work(config file compatibility) by merging this, but I think this is the right thing to do, so we'll merge this later on, next release I hope.

You could make changes until then.

tevino avatar Mar 31 '17 12:03 tevino

I do understand the friction it will cause due to config file changes. I'd like to test this a bit further, including proper tests and IPv6 support. Happy to work on this for the next release

badboy avatar Mar 31 '17 13:03 badboy

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 24 '23 10:02 CLAassistant

lol nope.

badboy avatar Feb 24 '23 11:02 badboy