pwa-asset-generator icon indicating copy to clipboard operation
pwa-asset-generator copied to clipboard

--single-quotes doesn't work as expected

Open caseywebdev opened this issue 3 years ago • 0 comments

I tried to use --single-quotes and noticed it made no difference in the output. Dug through the code and it looks like this line doesn't actually do anything because .replace doesn't mutate the original string.

https://github.com/onderceylan/pwa-asset-generator/blob/a444f76b937d17e621bb5bb22b6352ea3d4fa9f2/src/helpers/meta.ts#L180

The line would need to be more like

htmlMeta[metaKey] = metaContent.replaceAll('"', "'");

caseywebdev avatar Nov 10 '21 02:11 caseywebdev