David Phillips

Results 90 comments of David Phillips

Here's another example: ```java @SqlUpdate("CREATE TABLE IF NOT EXISTS nodes (\n" + " node_id INT PRIMARY KEY AUTO_INCREMENT,\n" + " node_identifier VARCHAR(255) NOT NULL,\n" + " UNIQUE (node_identifier)\n" + ")")...

@raunaqmorarka that's correct. Amazon has deprecated the v1 SDK, so we'll remove the old FS in the future. We plan to make the new one the default soon. @divincode please...

It would be great if you could help us tune the Trino defaults so that they work correctly out-of-the-box. We're using the AWS SDK defaults, so it's disappointing that it...

@my7ym Great work on reimplementing the Parquet code to not require Hadoop. I'll review this ASAP.

It looks like this code still depends on Hadoop. The config also contains a class name that is loaded at runtime, which is something we avoid in Trino. I think...

Apologies for the delay on following up on this. As @findepi mentioned, putting the skipping logic directly in the file system is problematic for deletes, and we really only want...

Hi @bangtim, take a look at `io.trino.plugin.hive.fs.DirectoryListingFilter` or `com.google.common.collect.AbstractIterator` for ideas on how to implement the skipping logic. The basic idea is that the iterator needs to do the filtering...

I don't think we need a new row change paradigm here. They both seem to do the same thing. Instead, `CHANGE_ONLY_UPDATED_COLUMNS` should support modifying only the affected columns. This is...

We should update the existing one to support updating a partial column list. This is a minor API difference and not a fundamentally different paradigm / model.

So I believe that the first commit is correct and the second commit is not needed.