EASTL icon indicating copy to clipboard operation
EASTL copied to clipboard

Do not use file(GLOB ...) to collect source files

Open zhmu opened this issue 3 years ago • 1 comments

This is specifically recommended against in the CMake documentation [1]:

"We do not recommend using GLOB to collect a list of source files from your source tree. [...]"

[1] https://cmake.org/cmake/help/v3.15/command/file.html#filesystem

zhmu avatar Oct 13 '21 16:10 zhmu

Hi there, We just pushed a new CI workflow that uses github actions since our existing travis CI hasn't been running on new PRs. Could you sync down the latest changes and update this PR? Once those checks succeed, we can move forward with this :) Thanks!

james-moran-ea avatar Feb 09 '22 19:02 james-moran-ea