Suraj Nath
Suraj Nath
I would love to see this, happy to review if someone PRs it in.
@makotonakai sure, go for it.
I see that `probe_failure_info` metric is trying to cover something that's should be covered by logs, and because of that I don't see the strong need to have this. Metrics...
> This is further complicated by the fact that failure reasons for probes are only visible with debug logging activated for probes, which generates so much logs, that a longer...
> 1. This issue would be solved by merging [Fix retrieving probe logs by target name when probed by multiple modules #1257](https://github.com/prometheus/blackbox_exporter/pull/1257). @slrtbtfs https://github.com/prometheus/blackbox_exporter/pull/1257 is merged into main and will...
closing, this was fixed in https://github.com/prometheus/blackbox_exporter/pull/1272, and included Release v0.27.0 #1431
> If just adding the tags is unwanted, I can also look into adding general support for json configs. We would need to add UnmarshalJSON functions like the UnmarshalYAML functions....
> also needs custom Unmarshal functions we don't mind having the JSON Unmarshal functions, it would be useful to folks using Blackbox exporter as a library and build on top...
> If wished I can also generate the json test cases during the test by converting the original yml test case to a json file. > Would remove the "duplicate"...
> Is it intended that the Config should not be Marshaled? Asking because when marshaling the Config all the Default values of the other modules are printed as well and...