windows-installer icon indicating copy to clipboard operation
windows-installer copied to clipboard

You must install both Mono and Wine on non-Windows

Open c19354837 opened this issue 6 years ago • 0 comments

Thanks for your awesome lib.

I notice in src/index.js line 23 - 30

  const monoExe = 'mono';
  const wineExe = 'wine';

  if (process.platform !== 'win32') {
    useMono = true;
    if (!wineExe || !monoExe) {
      throw new Error('You must install both Mono and Wine on non-Windows');
    }

    ...
  }

!wineExe || !monoExe will always be false, it's dead codes!

You must install both Mono and Wine on non-Windows is really important for non-windows users. Or you can add this in README.

BTW, I find this change from this PR

c19354837 avatar Aug 23 '18 08:08 c19354837