windows-installer icon indicating copy to clipboard operation
windows-installer copied to clipboard

is it possible codesign windows installer on OSX?

Open jayonthegreen opened this issue 7 years ago • 4 comments

const electronInstaller = require('electron-winstaller');
const path = require('path');
const fs = require('fs');
const appDirectory = 'foo'
const outputDirectory = 'foo'
const loadingGif = 'foo'
const setupIcon = 'foo'
const iconUrl = 'foo'
const certificateFile =  '%SOME_PATH%' // i'm using .pfx file

resultPromise = electronInstaller.createWindowsInstaller({
  appDirectory,
  outputDirectory,
  loadingGif,
  setupIcon,
  iconUrl,
  name: "FOO",
  description: "FOO",
  authors: 'COM',
  exe: 'FOO.exe',
  setupExe: 'FOO.exe',
  certificateFile: certificateFile,
  certificatePassword: 'XXXXX'
});
  • i'm using .pfx file

error stacktrace

No dice: Failed with exit code: 255
Output:
System.AggregateException: One or more errors occurred. ---> System.Exception: Failed to sign, command invoked was: '/Users/baegjaehyeon/Code/work/desktop/xxxx-desktop/node_modules/electron-winstaller/vendor/signtool.exe sign /a /f "/Users/baegjaehyeon/certificate/xxxx.co.kr.pfx" /p "xxxx" /Users/baegjaehyeon/.local/share/SquirrelTemp/tempa/lib/net45/libEGL.dll'
(...)

i think, beacuse of this library using 'signtool.exe', i have this problem. is it possible codesigning on osx?

jayonthegreen avatar May 19 '17 06:05 jayonthegreen

i just solved problem using codesign in mono

jayonthegreen avatar May 23 '17 08:05 jayonthegreen

@holdonnn are you signing the update.exe?

drjasonharrison avatar May 26 '17 18:05 drjasonharrison

Only electron-builder correctly sign Windows on macOS. User cannot do post code sign because some exe files are zipped during build. And, so, you need to change it in the Squirrel.Windows.

develar avatar May 26 '17 22:05 develar

@holdonnn how can you reproduce using codesign in mono?

benjtinsley avatar Jul 12 '18 21:07 benjtinsley