update-electron-app icon indicating copy to clipboard operation
update-electron-app copied to clipboard

Documentation doesn't state what assets need to be included in Github Releases

Open davidjmeyer opened this issue 1 year ago • 2 comments

The documentation mentions

For Windows, you'll need to build a .exe file and include it in your GitHub Release.

But this doesn't seem to be sufficient. When I try this I can see in the Squirrel-CheckForUpdate.log that it's trying to download the RELEASES file. It seems that I need to be uploading the -full.nupkg and RELEASES file to every GitHub release.

davidjmeyer avatar Aug 25 '23 06:08 davidjmeyer

Yeah, I agree.

To resolve that and see what is default, I ran the: npm run publish ----> env-cmd electron-forge publish

**PS: I use env-cmd because for this to work you need the GITHUB_TOKEN variable. And I like to put this in .env

After this, I have the three files published as a DRAFT RELEASE on Github: app.exe, app.nupkg, RELEASES

mepadev avatar Jan 27 '24 00:01 mepadev

You need to include the RELEASES file and any file it references - Squirrel.Windows is really simple:

  1. Read RELEASES file
  2. Compare versions
  3. Download the files listed in RELEASES file to move from $CURRENT_VERSION => $NEW_VERSION, either all of the deltas between $OLD and $NEW (hopefully just one), or the latest full release

anaisbetts avatar Jan 28 '24 14:01 anaisbetts