update-electron-app icon indicating copy to clipboard operation
update-electron-app copied to clipboard

Support Universal Apps

Open dgreene-r7 opened this issue 2 years ago • 1 comments

Currently the feed URL is constructed from process.arch which doesn't offer any insight into how the app that's calling it is built. I'm not sure it's possible for the running code to determine how the app has been built.

My sense is that having a matrix of possibilities (darwin + x64, darwin + arm64, darwin + universal) to check would be worthwhile. Obviously this will also require some work in https://github.com/electron/update.electronjs.org to support it; I've filed https://github.com/electron/update.electronjs.org/issues/140 to track that.

dgreene-r7 avatar Jul 19 '23 13:07 dgreene-r7

I think in theory we only need universal apps if the user doesn't know what they need to download, but when we are querying for updates, we know the user's architecture, like you suggest, there seems to be something like a preferred order to check:

  • <user's arch>
  • universal
  • finally falling back to x64 (since these can run on the m1s, and maybe what the user originally downloaded anyway).

Have you looked into the code at all to see if this is a straightforward enhancement you could put together a pull request for (both here and at update.electronjs.org)?

baparham avatar Jul 30 '23 14:07 baparham