symbolicate-mac icon indicating copy to clipboard operation
symbolicate-mac copied to clipboard

Published 20 hours ago • verified publisher icon electron

fix: improve speed 15x by using @indutny/breakpad

Open indutny opened this issue 1 year ago • 4 comments

Before:

$ npm test
Test Suites: 2 passed, 2 total
Tests:       7 passed, 7 total
Snapshots:   4 passed, 4 total
Time:        48.887 s

After:

$ npm test
Test Suites: 2 passed, 2 total
Tests:       7 passed, 7 total
Snapshots:   4 passed, 4 total
Time:        3.186 s

@indutny/breakpad also provides file/line number information, but I didn't want to make changes to the output format. Let me know if you want to add them in!

cc @nornagon

indutny avatar Jun 14 '24 17:06 indutny

Friendly ping @nornagon ?

indutny-signal avatar Jun 24 '24 15:06 indutny-signal

🤗 (keeping this up in the inbox!)

indutny-signal avatar Jul 01 '24 16:07 indutny-signal

Never give up :)

indutny-signal avatar Jul 11 '24 19:07 indutny-signal

🥹

indutny-signal avatar Aug 05 '24 23:08 indutny-signal

friendly ping?

tmm1 avatar Jan 16 '25 06:01 tmm1

Pinged @electron/wg-upgrades for secondary review, should be good to merge.

deepak1556 avatar Jan 17 '25 09:01 deepak1556

Yay!

indutny-signal avatar Jan 22 '25 21:01 indutny-signal

:tada: This PR is included in version 2.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

continuous-auth[bot] avatar Jan 22 '25 22:01 continuous-auth[bot]