rebuild: include prefix when filtering with --only
The logic currently ignores a module prefix when filtering packages
passed via --only=. This is quite confusing: to only rebuild
something like @theia/node-pty we must pass --only=node-pty.
This commit adds a lookup using the prefixed name.
I'm not sure if I should just replace .includes(modulePath) by .includes(`${prefix}{modulePath}`) as it might be breaking?
Codecov Report
Merging #850 (2d375d0) into master (26cae3d) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## master #850 +/- ##
=======================================
Coverage 75.89% 75.89%
=======================================
Files 17 17
Lines 672 672
Branches 130 130
=======================================
Hits 510 510
Misses 118 118
Partials 44 44
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/rebuild.ts | 66.29% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 26cae3d...2d375d0. Read the comment docs.
I added tests, but I'll need to close this PR temporarily, I will re-open when ready.
Ready to go again.
drafting due to conflicts. i think i can work on resolving them and getting this shipped.