rebuild icon indicating copy to clipboard operation
rebuild copied to clipboard

rebuild: include prefix when filtering with --only

Open paul-marechal opened this issue 4 years ago • 5 comments

The logic currently ignores a module prefix when filtering packages passed via --only=. This is quite confusing: to only rebuild something like @theia/node-pty we must pass --only=node-pty.

This commit adds a lookup using the prefixed name.

paul-marechal avatar Sep 02 '21 22:09 paul-marechal

I'm not sure if I should just replace .includes(modulePath) by .includes(`${prefix}{modulePath}`) as it might be breaking?

paul-marechal avatar Sep 02 '21 22:09 paul-marechal

Codecov Report

Merging #850 (2d375d0) into master (26cae3d) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #850   +/-   ##
=======================================
  Coverage   75.89%   75.89%           
=======================================
  Files          17       17           
  Lines         672      672           
  Branches      130      130           
=======================================
  Hits          510      510           
  Misses        118      118           
  Partials       44       44           
Impacted Files Coverage Δ
src/rebuild.ts 66.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26cae3d...2d375d0. Read the comment docs.

codecov-commenter avatar Sep 02 '21 22:09 codecov-commenter

I added tests, but I'll need to close this PR temporarily, I will re-open when ready.

paul-marechal avatar Sep 06 '21 03:09 paul-marechal

Ready to go again.

paul-marechal avatar Sep 10 '21 18:09 paul-marechal

drafting due to conflicts. i think i can work on resolving them and getting this shipped.

erickzhao avatar Nov 07 '23 22:11 erickzhao