rebuild icon indicating copy to clipboard operation
rebuild copied to clipboard

--prebuild-tag-prefix option cannot be empty

Open Badisi opened this issue 4 years ago • 0 comments

I'm trying to rebuild a prebuild package that doesn't have a tag prefix at all.

prebuild-install (works)

Not using a tag prefix is working fine with prebuild-install

prebuild-install --tag-prefix=''

The binary will be downloaded from : https://github.com/REPO/releases/download/TAG/

electron-rebuild (fail)

Not using a tag prefix is not working with electron-rebuild

electron-rebuild --prebuild-tag-prefix=''

The url will be : https://github.com/REPO/releases/download/vTAG/ (where the prefix will still be 'v') This is due to cli.ts#L141 and rebuild.ts#L91 where the test will fail even if the argument equals an empty string.

Badisi avatar Mar 22 '21 00:03 Badisi