rebuild icon indicating copy to clipboard operation
rebuild copied to clipboard

electron-rebuild is not compatible with Visual Studio 2017

Open gilz688 opened this issue 6 years ago • 2 comments

Electron Version: 1.8.4
OS: Windows 10 x64

My native module uses WinRT APIs in Windows 10 and requires at least Visual Studio 2017 (msbuild toolset v141). It builds fine when using node v9.11.1 and node-gyp v0.3 but errors occur when built using electron-rebuild v1.7.2.

I received the error below when using electron-rebuild:

c:\program files (x86)\windows kits\10\include\10.0.16299.0\winrt\wrl\def.h(48): fatal error C1189: #error: WRL requires NTDDI_VERSION to be #defined at least to NTDDI_VISTA or greater

gilz688 avatar Apr 12 '18 08:04 gilz688

Same for me apparently..

jracle avatar Aug 07 '18 10:08 jracle

Any update please?

jracle avatar Oct 03 '18 12:10 jracle