rebuild icon indicating copy to clipboard operation
rebuild copied to clipboard

feat: add support for node-gyp --jobs option to parallelize an indivi…

Open nkallen opened this issue 2 years ago • 4 comments

Hi,

I have a native module with a couple hundred c++ files. Electron-rebuild does have a "parallel" option but this doesn't actually run make in parallel WITHIN one module. This adds support for node-gyp's --jobs option, so that users like me can run electron-rebuild --jobs=max from the command line

Thanks

nkallen avatar Oct 01 '23 20:10 nkallen

Codecov Report

Merging #1106 (cbed90e) into main (bed3539) will increase coverage by 0.03%. Report is 5 commits behind head on main. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
+ Coverage   76.30%   76.34%   +0.03%     
==========================================
  Files          21       21              
  Lines         726      727       +1     
  Branches      136      137       +1     
==========================================
+ Hits          554      555       +1     
  Misses        121      121              
  Partials       51       51              
Files Coverage Δ
src/module-type/node-gyp/node-gyp.ts 83.87% <ø> (ø)
src/rebuild.ts 73.11% <100.00%> (+0.29%) :arrow_up:
src/types.ts 100.00% <ø> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-commenter avatar Oct 01 '23 21:10 codecov-commenter

Hi,

Are you guys not accepting submissions? I'm pretty Sure this is a useful feature for everyone

nkallen avatar Oct 12 '23 08:10 nkallen

ref https://github.com/electron/rebuild/issues/303

erickzhao avatar Nov 07 '23 21:11 erickzhao

References #303.

dsanders11 avatar Nov 07 '23 21:11 dsanders11