rcedit icon indicating copy to clipboard operation
rcedit copied to clipboard

fix: update the PE checksum after committing changes

Open rversteegen opened this issue 4 years ago • 2 comments

Fixes #50, #101

Yes, I was lazy and didn't bother to use GetLastError anywhere, because none of the other code does it...

rversteegen avatar Sep 06 '21 01:09 rversteegen

@dsanders11 any possible way to merge this?

gruselglatz avatar Jan 20 '25 12:01 gruselglatz

Hello!

Since the pull request was stuck with the old build system (and old commit), I've re-created the PR based on the latest commit here: https://github.com/FirehawkV21/rcedit/commit/495b73928ddbe467b3e7c8fe0ded8858b6472a08

I'd be happy to either bring over the changes to that fork or create a new PR that replaces it, if necessary.

EDIT: I realised that I mentioned the wrong PR on my fork's commit. It is this PR that I re-created.

FirehawkV21 avatar Jun 14 '25 08:06 FirehawkV21