packager icon indicating copy to clipboard operation
packager copied to clipboard

Set Icon for Helper app

Open brandonhorst opened this issue 6 years ago • 3 comments

  • [x] I have read the contribution documentation for this project.
  • [x] I agree to follow the code of conduct that this project follows, as appropriate.
  • [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:

On MacOS, If you trigger a User Notification from a renderer process (e.g. via a Native Addon), the notification is given a placeholder icon, because the owning .app (the Helper) lacks an icon.

image

If you specify an Icon, that Icon should also be used for the Helper Apps, or there should be an option to specify the Helper app icon separately.

brandonhorst avatar Feb 24 '19 21:02 brandonhorst

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

welcome[bot] avatar Feb 24 '19 21:02 welcome[bot]

It would be great if someone had a proposal that included what the API option would look like and what the CLI option would look like.

malept avatar Feb 25 '19 07:02 malept

I do not If it well help But I found That If <App Name Ex: myapp> in CMD is same as in Package.json "name": "myapp" it will set as electron icon even with UPPERCASE change Ex: MYAPP

And after many tries I found that when I change

App Name Ex: MyFirstApp

The myapp Icon is set in EXE file.

electron-packager <sourcedir> <MyFirstApp> --platform=<platform> --arch=<arch> [optional flags...]

ockba-a avatar Dec 08 '19 23:12 ockba-a