Move asar process after copyExtraResources

[nick-michael]

• [x] I have read the contribution documentation for this project.
• [x] I agree to follow the code of conduct that this project follows, as appropriate.
• [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Spec: We have a requirement to execute some code after the icons and name change have all been complete, but before the app.asar has been generated.

Looking at the code we can't see any reason that the asar needs to happen during the initialize, and would like to make a change to move this after the .then(() => this.copyExtraResources()) has been executed. We then need a hook similar to afterCopy and afterPrune e.t.c. that we can tap into. This would either be done as an afterCopyExtraResources hook or a beforeAsar hook, whichever is preferred.

Before we get working on this it would be great to have some feedback as to whether a PR for this would be accepted, and any ideas about the implementation (for example, the choice between a before and after hook)

[welcome[bot]]

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

[malept]

I think instead of more arbitrary hooks, I would prefer if someone implemented #509.

[njbmartin]

@malept #509 doesn't resolve the issue raise here. For one, start / complete are unnecessary as this is inferred just by it's execution, and what is suggested for progress is not an event hook, but an EventEmitter which would not allow for additional code execution between steps. The progress percentage would also be fairly arbitrary.

Edit: I'll add a comment to that issue.