packager icon indicating copy to clipboard operation
packager copied to clipboard

fix(types): add "universal" as a valid arch

Open erickzhao opened this issue 3 years ago • 2 comments

  • [x] I have read the contribution documentation for this project.
  • [x] I agree to follow the code of conduct that this project follows, as appropriate.
  • [x] The changes are appropriately documented (if applicable).
  • [x] The changes have sufficient test coverage (if applicable).
  • [ ] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Adds a missing typing in https://github.com/electron/electron-packager/pull/1346.

erickzhao avatar Aug 23 '22 21:08 erickzhao

Codecov Report

Merging #1407 (7cd5eb1) into main (0d692d7) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1407   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          15       15           
  Lines         776      776           
=======================================
  Hits          742      742           
  Misses         34       34           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 23 '22 21:08 codecov[bot]

Add to typing tests?

malept avatar Aug 23 '22 21:08 malept