packager
packager copied to clipboard
fix: ignore node_gyp_bins if it exists
- [x] I have read the contribution documentation for this project.
- [x] I agree to follow the code of conduct that this project follows, as appropriate.
- [x] The changes are appropriately documented (if applicable).
- [x] The changes have sufficient test coverage (if applicable).
- [x] The testsuite passes successfully on my local machine (if applicable). (Passes on MacOS Monterey x64 & arm64)
Addresses https://github.com/electron/electron-rebuild/issues/1024
In node-gyp v9.0.0, node-gyp adds a python symlink for older versions of python. This symlink is added to a ${module_name}/build/node_gyp_bins/ directory within the build directory, which electron-rebuild then tries to rebuild.
This PR ignores the node_gyp_bins directory, and adds tests for making sure that the directory is not added to the packaged app.
Thanks for opening a pull request!
Here are some highlighted action items that will help get it across the finish line, from the pull request guidelines:
- Follow the JavaScript coding style.
- Run
npm run lintlocally to catch formatting errors earlier. - Document any user-facing changes in
NEWS.mdand other docs. - Include tests when adding/changing behavior.
Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.
Hmmm. Separate PR to fix the xcode version in use, so the tests pass?
@malept Yeah, hilariously that image failure is new as of this afternoon's rerun 😄 I'll fix that in another PR and then rebase
Codecov Report
Merging #1391 (7f1bc03) into main (c6b4c78) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main #1391 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 15 15
Lines 776 776
=======================================
Hits 742 742
Misses 34 34
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/copy-filter.js | 100.00% <ø> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more