packager
packager copied to clipboard
debug notarize options
- [X] I have read the contribution documentation for this project.
- [X] I agree to follow the code of conduct that this project follows, as appropriate.
- [ ] The changes are appropriately documented (if applicable).
- [ ] The changes have sufficient test coverage (if applicable).
- [ ] The testsuite passes successfully on my local machine (if applicable).
Summarize your changes: Add debug output for electron-notarize options
Thanks for opening a pull request!
Here are some highlighted action items that will help get it across the finish line, from the pull request guidelines:
- Follow the JavaScript coding style.
- Run
npm run lintlocally to catch formatting errors earlier. - Document any user-facing changes in
NEWS.mdand other docs. - Include tests when adding/changing behavior.
Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.
These options can contain credentials, we should avoid logging them
Okay. I assumed it wasn't a concern because the Packager Options debug output here could contain the same credentials