packager icon indicating copy to clipboard operation
packager copied to clipboard

feat: New lifecycle hooks: afterAsar, afterComplete, afterCopyExtraResources, beforeAsar, beforeCopy, beforeCopyExtraResources

Open erikian opened this issue 3 years ago • 3 comments

  • [x] I have read the contribution documentation for this project.
  • [x] I agree to follow the code of conduct that this project follows, as appropriate.
  • [x] The changes are appropriately documented (if applicable).
  • [x] The changes have sufficient test coverage (if applicable).
  • [x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes: This PR partially addresses #509 with the following new lifecycle methods: afterAsar, afterComplete, afterCopyExtraResources, beforeAsar, beforeCopy, beforeCopyExtraResources. There's definitely room for improvement, so any feedback is welcome.

erikian avatar Oct 28 '21 03:10 erikian

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

welcome[bot] avatar Oct 28 '21 03:10 welcome[bot]

Codecov Report

Merging #1297 (1a93df3) into main (21bb953) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
+ Coverage   95.47%   95.54%   +0.06%     
==========================================
  Files          15       15              
  Lines         774      785      +11     
==========================================
+ Hits          739      750      +11     
  Misses         35       35              
Impacted Files Coverage Δ
src/platform.js 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Oct 28 '21 03:10 codecov[bot]

If there's anything I can do to help move this along, please let me know. 🙂

erikian avatar Jan 26 '22 22:01 erikian

Thanks for your contribution! 🎉

welcome[bot] avatar Oct 25 '22 23:10 welcome[bot]