node icon indicating copy to clipboard operation
node copied to clipboard

fix: remove array buffer allocator patch (electron-4.x)

Open deepak1556 opened this issue 6 years ago • 1 comments

This PR removes our array buffer allocator patch for 10.11.0 branch and replace it with official version from https://github.com/nodejs/node/pull/26207 . The main reason being the patch isn't audited with every node version upgrade and is source of potential allocation errors https://github.com/electron/electron/search?q=set+a+breakpoint+in+malloc_error_break+to+debug&type=Issues .

In VSCode based on electron 4.x we have been seeing these crashes https://github.com/microsoft/vscode/issues/76197.

We don't have a reliable repro for the crashes because the symbols are borked, hoping to get some data with https://github.com/electron/electron/pull/19158 in future releases. So at the moment I decided to choose the route of removing our patch for the official version as a possible solution.

I don't have hopes for this solution getting into electron 4.x with it being a stable release, but would still like to get a review. Thanks!

deepak1556 avatar Jul 10 '19 10:07 deepak1556

/cc @addaleax would be great to get your review whenever possible. Thanks!

deepak1556 avatar Jul 10 '19 10:07 deepak1556