get icon indicating copy to clipboard operation
get copied to clipboard

fix: support npmrc for custom-version env variable

Open felixrieseberg opened this issue 3 years ago • 2 comments

Reopened https://github.com/electron/get/pull/219 here because CircleCi didn't want to run builds from forks

Fixes following problems:

  • It is not possible to define CUSTOM_VERSION env variable via .npmrc together with others.
  • it was not picking up customDir and nightlyMirror from the mirrorConfig properly

felixrieseberg avatar May 06 '22 15:05 felixrieseberg

@felixrieseberg looks sane to me.

Is it easy to add a test for this?

Yes, I can do that

ddramone avatar May 17 '22 15:05 ddramone

Hi @felixrieseberg

I added a test in this commit

I'm not sure how can I push it to this PR since it was created by you.

ddramone avatar May 26 '22 13:05 ddramone

:tada: This PR is included in version 2.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

electron-bot avatar Sep 09 '22 17:09 electron-bot