forge icon indicating copy to clipboard operation
forge copied to clipboard

feat: Publisher S3 add ChecksumCalculation

Open Dexus opened this issue 9 months ago • 1 comments

  • [x] I have read the contribution documentation for this project.
  • [x] I agree to follow the code of conduct that this project follows, as appropriate.
  • [x] The changes are appropriately documented (if applicable).
  • [x] The changes have sufficient test coverage (if applicable).
  • [x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This pull request introduces new configuration options for checksum handling in the PublisherS3 class. The changes primarily focus on allowing users to control checksum calculations and validations for requests and responses to and from S3.

This is local only tested against backblaze S3 and cloudflare R2.

Configuration Enhancements:

  • packages/publisher/s3/src/Config.ts: Added requestChecksumCalculation and responseChecksumValidation options to the PublisherS3Config interface. These options allow users to specify when checksums should be calculated and validated, respectively.

Implementation Updates:

  • packages/publisher/s3/src/PublisherS3.ts: Updated the PublisherS3 class to include the new checksum configuration options when creating the S3 client. Default values are set to "WHEN_SUPPORTED" if not provided.

Dexus avatar Apr 01 '25 08:04 Dexus

ping @erickzhao

Dexus avatar Apr 29 '25 18:04 Dexus