forge icon indicating copy to clipboard operation
forge copied to clipboard

fix(package): set `process.env.npm_config_arch` for each arch in universal build

Open busterbogheart opened this issue 9 months ago • 3 comments

  • [x] I have read the contribution documentation for this project.
  • [x] I agree to follow the code of conduct that this project follows, as appropriate.
  • [x] The changes are appropriately documented (if applicable).
  • [x] The changes have sufficient test coverage (if applicable).
  • [x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Closes #3657

This one line will set process.env.npm_config_arch to the appropriate architecture as the build creates multiple versions for the Mac universal app.

busterbogheart avatar Mar 13 '25 15:03 busterbogheart

@MarshallOfSound

its anoying to workaround all this shit, the patch here, is working semi good. Maybe for some of the packages, but there ist still more todo...

use the package: @deepnest/svg-preprocessor it has optional packages each for different platforms and architectures.

Same problem also for prebuilds from prebuildify like @deepnest/calculate-nfp

both should be able to load for universal builds, but don't. And I'm currently not sure, what I can do, to let it build correctly. Currently I'm try this: https://github.com/Dexus/Deepnest/blob/9a1cd7bb1c1829037f5445a4c48e7bb333a8e6b5/forge.config.js#L61-L133

Dexus avatar Mar 31 '25 16:03 Dexus

Same comment as above, gesturing wildly at random packages and saying "this doesn't work" is not helpful.

The maintainers have limited bandwidth, if you want someone to look at a thing seriously, provide a repro case. A tiny repo (not a giant app) that demonstrates the problem you are reporting. If you do, it's much more likely people will be able to help you.

MarshallOfSound avatar Mar 31 '25 16:03 MarshallOfSound

Checkout this REPO: https://github.com/Dexus/Deepnest.git and then checkout to 9e2181aac5dc950d3d0fac4e836e3f81f17073e0 run and get your errors.

Dexus avatar Mar 31 '25 17:03 Dexus