forge icon indicating copy to clipboard operation
forge copied to clipboard

fix(plugin-vite): stop the world

Open smallsung opened this issue 1 year ago • 0 comments

  • [x] I have read the contribution documentation for this project.
  • [x] I agree to follow the code of conduct that this project follows, as appropriate.
  • [ ] The changes are appropriately documented (if applicable).
  • [ ] The changes have sufficient test coverage (if applicable).
  • [x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes: Run yarn run start. Under the default configuration, vite.build will call rollup.watch. If the first build fails, Promise.all will never be resolved.

https://github.com/electron/forge/blob/7574b364901ec429220dbe7076184585a99529a5/packages/plugin/vite/src/VitePlugin.ts#L155-L183

smallsung avatar Oct 10 '24 16:10 smallsung