forge icon indicating copy to clipboard operation
forge copied to clipboard

feat(makerdeb): Add name option and fix bin name

Open coredev-uk opened this issue 1 year ago • 3 comments

  • [x] I have read the contribution documentation for this project.
  • [x] I agree to follow the code of conduct that this project follows, as appropriate.
  • [x] The changes are appropriately documented (if applicable).
  • [x] The changes have sufficient test coverage (if applicable).
  • [x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes: Basically as the title says, this implements a rename function to correct the file name of the .deb output to the user specified value. This also corrects the bin name to enforce the use of the executableName. In situations where the app name in the package.json does not match the executableName in the packagerConfig it errors due to package generating an executable following the executableName value which is not what MakerDeb is expecting.

coredev-uk avatar Oct 02 '24 01:10 coredev-uk

This looks good, thanks for the contribution @coredev-uk! The only question I have is whether or not this might be a breaking change for anyone - what's your take?

felixrieseberg avatar Oct 18 '24 16:10 felixrieseberg

This does slightly change the default file name, current structure is $NAME-$PLATFORM-$ARCH-$VERSION-$DEBARCH.deb, this PR does change it to a simpler format which could potentially cause some issues in a CI environment if people are explicitly setting the filename. Would you suggest I set the default to the current one?

coredev-uk avatar Oct 19 '24 15:10 coredev-uk

Seems this is not going anywhere.

coredev-uk avatar Feb 20 '25 20:02 coredev-uk