feat(publisher-gcs): implemented Google Cloud Storage publisher

[mahnunchik]

Continue of https://github.com/electron-userland/electron-forge/pull/1752

[codecov[bot]]

Codecov Report

Merging #2100 (593f2c3) into master (7050550) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2100   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          74       74           
  Lines        2221     2221           
  Branches      420      420           
=======================================
  Hits         1615     1615           
  Misses        446      446           
  Partials      160      160           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7050550...593f2c3. Read the comment docs.

[mahnunchik]

Hi @malept could you please review this PR.

[mahnunchik]

@malept 😢

[mahnunchik]

Hi @malept when my PR may be accepted?

[mahnunchik]

@erickzhao What about Google Cloud Storage publisher? I really need it for my workflow

[mahnunchik]

@MarshallOfSound @erickzhao @BlackHole1 I've decided to rebase on top of current main and squash to single commit.

[mahnunchik]

Should I rebase PR again?

[mahnunchik]

@erickzhao I was able to rebase PR on top of current main by fighting the dependency hell... I make GCS publisher looks like S3 publisher and ported changes from it.

Could you please help me to ship GCS publisher before main have many new changes?

[nikashitsa]

Useful feature for me also.

[mahnunchik]

@erickzhao could I ask for a review of this PR?

[mahnunchik]

@erickzhao I've rebase PR on top of current changes. Could you please tell me what should I do to have this PR merged?

[mahnunchik]

I'm using this publisher for a years, published by my package name. Could we make this PR merged?

[mahnunchik]

@MarshallOfSound @erickzhao I need this publisher in the application. What can I do to get the PR accepted?

[mahnunchik]

@MarshallOfSound @erikian @erickzhao ping

[BlackHole1]

Hi @mahnunchik . I saw @erickzhao commented on some issues. If they have been resolved, you can click the “Resolve conversation” button. If you have any questions regarding the issues, you can comment below. This will help other maintainers with the code review.

[mahnunchik]

@BlackHole1 @erickzhao All open conversations was commented by me. GCS publisher is based on S3 publisher, I think both should be close as possible.

[erickzhao]

Here are the tweaks I propose: all the auth-related Storage constructor options should be nested in their own property:

https://github.com/mahnunchik/electron-forge/pull/364

This way we aren't limiting ourselves to a subset of the credential options available via the @google-cloud/storage module, and it's less confusing to have all these options available at the top-level publisher config.

[mahnunchik]

@erickzhao Thank you for your help! Implementation has become much simpler and clearer.

Should I close conversations above? I think everything is fixed now.

[erickzhao]

I think everything is fixed! We're planning on releasing a new Forge version within the next week, so hopefully this can make its way in.

[erickzhao]

Rebased after the 7.0.0 breaking change release. Once CI is green, going to merge this and get it into a 7.1.0 release before the end of the month.