forge icon indicating copy to clipboard operation
forge copied to clipboard

feat(maker-pkg): allow to override .pkg name

Open mahnunchik opened this issue 5 years ago • 6 comments

ISSUES CLOSED: #1784

  • [x] I have read the contribution documentation for this project.
  • [x] I agree to follow the code of conduct that this project follows, as appropriate.
  • [x] The changes are appropriately documented (if applicable).
  • [ ] The changes have sufficient test coverage (if applicable).
  • [ ] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Allow to override .pkg filename.

mahnunchik avatar Jun 22 '20 18:06 mahnunchik

@malept could you please have a look at this PR

mahnunchik avatar Jul 10 '20 13:07 mahnunchik

@malept What should I do to have this PR merged?

mahnunchik avatar Oct 14 '20 10:10 mahnunchik

Codecov Report

Merging #1785 (384dda9) into master (4824af6) will increase coverage by 12.42%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1785       +/-   ##
===========================================
+ Coverage   60.28%   72.71%   +12.42%     
===========================================
  Files          71       74        +3     
  Lines        2153     2221       +68     
  Branches      411      421       +10     
===========================================
+ Hits         1298     1615      +317     
+ Misses        676      446      -230     
+ Partials      179      160       -19     
Impacted Files Coverage Δ
packages/maker/pkg/src/MakerPKG.ts 92.85% <100.00%> (ø)
packages/utils/async-ora/src/index.ts 100.00% <0.00%> (ø)
packages/maker/squirrel/src/MakerSquirrel.ts 77.27% <0.00%> (ø)
packages/maker/zip/src/MakerZIP.ts 100.00% <0.00%> (ø)
packages/maker/wix/src/MakerWix.ts 86.36% <0.00%> (ø)
packages/utils/test-utils/src/index.ts 85.71% <0.00%> (+3.10%) :arrow_up:
packages/utils/async-ora/src/ora-handler.ts 90.00% <0.00%> (+3.33%) :arrow_up:
packages/maker/deb/src/MakerDeb.ts 100.00% <0.00%> (+5.26%) :arrow_up:
packages/maker/rpm/src/MakerRpm.ts 100.00% <0.00%> (+5.26%) :arrow_up:
packages/maker/dmg/src/MakerDMG.ts 100.00% <0.00%> (+5.55%) :arrow_up:
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4824af6...384dda9. Read the comment docs.

codecov[bot] avatar Dec 18 '20 11:12 codecov[bot]

@malept PR has been updated on latest master.

mahnunchik avatar Dec 18 '20 11:12 mahnunchik

@malept ping

mahnunchik avatar Jun 21 '21 12:06 mahnunchik

@malept ping

rebasegoblin avatar Mar 02 '22 09:03 rebasegoblin

Done! I'm looking forward to have it merged.

mahnunchik avatar Nov 09 '22 07:11 mahnunchik

Hey @mahnunchik CI failed.

image

Can you execute Prettier locally?

BlackHole1 avatar Nov 09 '22 08:11 BlackHole1

All done!

mahnunchik avatar Nov 09 '22 09:11 mahnunchik

@mahnunchik This PR has a conflict because https://github.com/electron/forge/pull/3057 was merged, can you fix it? 🙇‍♂️

BlackHole1 avatar Nov 10 '22 02:11 BlackHole1

@BlackHole1 what is wrong with CI tests? I've rebased PR on current main.

mahnunchik avatar Nov 11 '22 13:11 mahnunchik

Test case need modify and should be a simple.

BlackHole1 avatar Nov 11 '22 14:11 BlackHole1

@BlackHole1 mistypo while rebase has been fixed

mahnunchik avatar Nov 11 '22 14:11 mahnunchik

I'm looking forward to have this PR merged 😉

mahnunchik avatar Nov 14 '22 12:11 mahnunchik