feat(maker-pkg): allow to override .pkg name
ISSUES CLOSED: #1784
- [x] I have read the contribution documentation for this project.
- [x] I agree to follow the code of conduct that this project follows, as appropriate.
- [x] The changes are appropriately documented (if applicable).
- [ ] The changes have sufficient test coverage (if applicable).
- [ ] The testsuite passes successfully on my local machine (if applicable).
Summarize your changes:
Allow to override .pkg filename.
@malept could you please have a look at this PR
@malept What should I do to have this PR merged?
Codecov Report
Merging #1785 (384dda9) into master (4824af6) will increase coverage by
12.42%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #1785 +/- ##
===========================================
+ Coverage 60.28% 72.71% +12.42%
===========================================
Files 71 74 +3
Lines 2153 2221 +68
Branches 411 421 +10
===========================================
+ Hits 1298 1615 +317
+ Misses 676 446 -230
+ Partials 179 160 -19
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/maker/pkg/src/MakerPKG.ts | 92.85% <100.00%> (ø) |
|
| packages/utils/async-ora/src/index.ts | 100.00% <0.00%> (ø) |
|
| packages/maker/squirrel/src/MakerSquirrel.ts | 77.27% <0.00%> (ø) |
|
| packages/maker/zip/src/MakerZIP.ts | 100.00% <0.00%> (ø) |
|
| packages/maker/wix/src/MakerWix.ts | 86.36% <0.00%> (ø) |
|
| packages/utils/test-utils/src/index.ts | 85.71% <0.00%> (+3.10%) |
:arrow_up: |
| packages/utils/async-ora/src/ora-handler.ts | 90.00% <0.00%> (+3.33%) |
:arrow_up: |
| packages/maker/deb/src/MakerDeb.ts | 100.00% <0.00%> (+5.26%) |
:arrow_up: |
| packages/maker/rpm/src/MakerRpm.ts | 100.00% <0.00%> (+5.26%) |
:arrow_up: |
| packages/maker/dmg/src/MakerDMG.ts | 100.00% <0.00%> (+5.55%) |
:arrow_up: |
| ... and 21 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4824af6...384dda9. Read the comment docs.
@malept PR has been updated on latest master.
@malept ping
@malept ping
Done! I'm looking forward to have it merged.
Hey @mahnunchik CI failed.
Can you execute Prettier locally?
All done!
@mahnunchik This PR has a conflict because https://github.com/electron/forge/pull/3057 was merged, can you fix it? 🙇♂️
@BlackHole1 what is wrong with CI tests? I've rebased PR on current main.
Test case need modify and should be a simple.
@BlackHole1 mistypo while rebase has been fixed
I'm looking forward to have this PR merged 😉