feat (publisher-github): assets management
- [x] I have read the contribution documentation for this project.
- [x] I agree to follow the code of conduct that this project follows, as appropriate.
- [ ] The changes are appropriately documented (if applicable).
- [ ] The changes have sufficient test coverage (if applicable).
- [ ] The testsuite passes successfully on my local machine (if applicable).
Summarize your changes:
This PR includes fixes related to publisher-gihub:
- Replace special characters in the asset name https://github.com/electron-userland/electron-forge/issues/1759
- Allow to override existing asset of release https://github.com/electron-userland/electron-forge/issues/1760
It would be awesome to remove deprecation warning by merging this PR: https://github.com/electron-userland/electron-forge/pull/1673 But there are broken tests.
@malept is it possible to have it merged?
@malept What should I do to have this PR merged?
Codecov Report
Merging #1761 (e15c362) into master (4824af6) will increase coverage by
12.45%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #1761 +/- ##
===========================================
+ Coverage 60.28% 72.73% +12.45%
===========================================
Files 71 74 +3
Lines 2153 2223 +70
Branches 411 420 +9
===========================================
+ Hits 1298 1617 +319
+ Misses 676 446 -230
+ Partials 179 160 -19
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/publisher/github/src/util/github.ts | 100.00% <100.00%> (ø) |
|
| packages/utils/async-ora/src/index.ts | 100.00% <0.00%> (ø) |
|
| packages/maker/wix/src/MakerWix.ts | 86.36% <0.00%> (ø) |
|
| packages/maker/zip/src/MakerZIP.ts | 100.00% <0.00%> (ø) |
|
| packages/maker/squirrel/src/MakerSquirrel.ts | 77.27% <0.00%> (ø) |
|
| packages/utils/test-utils/src/index.ts | 85.71% <0.00%> (+3.10%) |
:arrow_up: |
| packages/utils/async-ora/src/ora-handler.ts | 90.00% <0.00%> (+3.33%) |
:arrow_up: |
| packages/maker/deb/src/MakerDeb.ts | 100.00% <0.00%> (+5.26%) |
:arrow_up: |
| packages/maker/rpm/src/MakerRpm.ts | 100.00% <0.00%> (+5.26%) |
:arrow_up: |
| packages/maker/dmg/src/MakerDMG.ts | 100.00% <0.00%> (+5.55%) |
:arrow_up: |
| ... and 21 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4824af6...e15c362. Read the comment docs.
@malept any chance to have this PR merged?
@malept ping again
Just rebased this with latest main
@erickzhao deleting all assets is not suitable for me because assets uploaded per platform, so multiple publishers will remove assets of each other.
@erickzhao I think it is ok to ship sanitizeName as is and fix it in case of incorrect name generation in the future.
@erickzhao could we have it merged? Should I rebase PR?
Could it be merged?
@erickzhao @malept I've rebased on top of current main branch. Could the PR be merged or should I change something?