forge icon indicating copy to clipboard operation
forge copied to clipboard

feat (publisher-github): assets management

Open mahnunchik opened this issue 5 years ago • 6 comments

  • [x] I have read the contribution documentation for this project.
  • [x] I agree to follow the code of conduct that this project follows, as appropriate.
  • [ ] The changes are appropriately documented (if applicable).
  • [ ] The changes have sufficient test coverage (if applicable).
  • [ ] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This PR includes fixes related to publisher-gihub:

  • Replace special characters in the asset name https://github.com/electron-userland/electron-forge/issues/1759
  • Allow to override existing asset of release https://github.com/electron-userland/electron-forge/issues/1760

mahnunchik avatar Jun 11 '20 16:06 mahnunchik

It would be awesome to remove deprecation warning by merging this PR: https://github.com/electron-userland/electron-forge/pull/1673 But there are broken tests.

mahnunchik avatar Jun 11 '20 16:06 mahnunchik

@malept is it possible to have it merged?

mahnunchik avatar Jul 10 '20 13:07 mahnunchik

@malept What should I do to have this PR merged?

mahnunchik avatar Oct 14 '20 10:10 mahnunchik

Codecov Report

Merging #1761 (e15c362) into master (4824af6) will increase coverage by 12.45%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1761       +/-   ##
===========================================
+ Coverage   60.28%   72.73%   +12.45%     
===========================================
  Files          71       74        +3     
  Lines        2153     2223       +70     
  Branches      411      420        +9     
===========================================
+ Hits         1298     1617      +319     
+ Misses        676      446      -230     
+ Partials      179      160       -19     
Impacted Files Coverage Δ
packages/publisher/github/src/util/github.ts 100.00% <100.00%> (ø)
packages/utils/async-ora/src/index.ts 100.00% <0.00%> (ø)
packages/maker/wix/src/MakerWix.ts 86.36% <0.00%> (ø)
packages/maker/zip/src/MakerZIP.ts 100.00% <0.00%> (ø)
packages/maker/squirrel/src/MakerSquirrel.ts 77.27% <0.00%> (ø)
packages/utils/test-utils/src/index.ts 85.71% <0.00%> (+3.10%) :arrow_up:
packages/utils/async-ora/src/ora-handler.ts 90.00% <0.00%> (+3.33%) :arrow_up:
packages/maker/deb/src/MakerDeb.ts 100.00% <0.00%> (+5.26%) :arrow_up:
packages/maker/rpm/src/MakerRpm.ts 100.00% <0.00%> (+5.26%) :arrow_up:
packages/maker/dmg/src/MakerDMG.ts 100.00% <0.00%> (+5.55%) :arrow_up:
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4824af6...e15c362. Read the comment docs.

codecov[bot] avatar Dec 18 '20 14:12 codecov[bot]

@malept any chance to have this PR merged?

mahnunchik avatar Feb 02 '21 09:02 mahnunchik

@malept ping again

mahnunchik avatar Jun 21 '21 12:06 mahnunchik

Just rebased this with latest main

erickzhao avatar Nov 07 '22 22:11 erickzhao

@erickzhao deleting all assets is not suitable for me because assets uploaded per platform, so multiple publishers will remove assets of each other.

mahnunchik avatar Nov 09 '22 08:11 mahnunchik

@erickzhao I think it is ok to ship sanitizeName as is and fix it in case of incorrect name generation in the future.

mahnunchik avatar Nov 11 '22 13:11 mahnunchik

@erickzhao could we have it merged? Should I rebase PR?

mahnunchik avatar Jan 13 '23 13:01 mahnunchik

Could it be merged?

mahnunchik avatar Sep 21 '23 16:09 mahnunchik

@erickzhao @malept I've rebased on top of current main branch. Could the PR be merged or should I change something?

mahnunchik avatar Sep 22 '23 21:09 mahnunchik