forge icon indicating copy to clipboard operation
forge copied to clipboard

fix (maker-dmg): added missing title option

Open mahnunchik opened this issue 5 years ago • 4 comments

  • [x] I have read the contribution documentation for this project.
  • [x] I agree to follow the code of conduct that this project follows, as appropriate.
  • [ ] The changes are appropriately documented (if applicable).
  • [ ] The changes have sufficient test coverage (if applicable).
  • [ ] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Added missing title option: https://github.com/electron-userland/electron-installer-dmg#api

mahnunchik avatar Jun 10 '20 19:06 mahnunchik

I think it's more appropriate to add a TypeScript definition to electron-installer-dmg and effectively replace Config.ts with that, than add missing config to a Forge-specific definition. See #1644 for a similar action that happened with electron-installer-snap.

malept avatar Jun 11 '20 16:06 malept

I definitely agree with it.

mahnunchik avatar Jun 11 '20 17:06 mahnunchik

Codecov Report

Merging #1755 (80b3bcd) into master (4824af6) will increase coverage by 12.42%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1755       +/-   ##
===========================================
+ Coverage   60.28%   72.71%   +12.42%     
===========================================
  Files          71       74        +3     
  Lines        2153     2221       +68     
  Branches      411      420        +9     
===========================================
+ Hits         1298     1615      +317     
+ Misses        676      446      -230     
+ Partials      179      160       -19     
Impacted Files Coverage Δ
packages/utils/async-ora/src/index.ts 100.00% <0.00%> (ø)
packages/maker/wix/src/MakerWix.ts 86.36% <0.00%> (ø)
packages/maker/zip/src/MakerZIP.ts 100.00% <0.00%> (ø)
packages/maker/squirrel/src/MakerSquirrel.ts 77.27% <0.00%> (ø)
packages/utils/test-utils/src/index.ts 85.71% <0.00%> (+3.10%) :arrow_up:
packages/utils/async-ora/src/ora-handler.ts 90.00% <0.00%> (+3.33%) :arrow_up:
packages/maker/deb/src/MakerDeb.ts 100.00% <0.00%> (+5.26%) :arrow_up:
packages/maker/rpm/src/MakerRpm.ts 100.00% <0.00%> (+5.26%) :arrow_up:
packages/maker/dmg/src/MakerDMG.ts 100.00% <0.00%> (+5.55%) :arrow_up:
packages/plugin/base/src/Plugin.ts 66.66% <0.00%> (+6.66%) :arrow_up:
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4824af6...80b3bcd. Read the comment docs.

codecov[bot] avatar Dec 18 '20 13:12 codecov[bot]

@malept meanwhile i think it simpler to apply this PR. I have to override default title in my app. I updated PR on latest master.

mahnunchik avatar Dec 18 '20 13:12 mahnunchik

Closing this in favour of https://github.com/electron-userland/electron-installer-dmg/pull/178

erickzhao avatar Nov 08 '22 18:11 erickzhao