forge icon indicating copy to clipboard operation
forge copied to clipboard

Update: PublisherERS.ts to include rc as a channel

Open craigwduckett opened this issue 5 years ago • 1 comments

  • [x] I have read the contribution documentation for this project.
  • [x] I agree to follow the code of conduct that this project follows, as appropriate.
  • [x] The changes are appropriately documented (if applicable).
  • [x] The changes have sufficient test coverage (if applicable).
  • [x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes: Added a check to ERS uploader for rc channel in the version string as this is one of the default channels created in ERS.

craigwduckett avatar Oct 08 '19 03:10 craigwduckett

Codecov Report

Merging #1219 into master will increase coverage by 0.3%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1219     +/-   ##
=========================================
+ Coverage   67.82%   68.13%   +0.3%     
=========================================
  Files          67       67             
  Lines        1958     1958             
  Branches      378      378             
=========================================
+ Hits         1328     1334      +6     
+ Misses        454      451      -3     
+ Partials      176      173      -3
Impacted Files Coverage Δ
packages/api/cli/src/util/check-system.ts 78.94% <0%> (+5.26%) :arrow_up:
packages/api/core/src/util/electron-version.ts 96.07% <0%> (+7.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 80c5ad7...faa2662. Read the comment docs.

codecov[bot] avatar Oct 08 '19 04:10 codecov[bot]