fiddle icon indicating copy to clipboard operation
fiddle copied to clipboard

Published 20 hours ago • verified publisher icon electron

Inconsistent focus indicators throughout Fiddle

Open carolstran opened this issue 2 years ago • 5 comments

👋🏼 While tabbing around, I noticed that the focus indicators are inconsistent:

  • Text inputs with the bp3-input class have a default blue outline
  • Some input elements have a background-color: @foreground-2; style applied on focus (which I'm guessing is meant to change the outline)
  • Other focusable elements (like checkboxes) have an additional white outline
  • https://github.com/electron/fiddle/issues/1084

I've opened a separate issue for the buttons as this is a more severe accessibility issue, but the rest are more of a matter of styling and preference 🤷🏼‍♀️

Screenshot from the settings page for reference:

carolstran avatar May 26 '22 20:05 carolstran

Can I work on this issue ?

kirtanchandak avatar Sep 17 '22 07:09 kirtanchandak

Can I work on this issue ?

@kirtanchandak Sure.

BlackHole1 avatar Sep 17 '22 07:09 BlackHole1

Hey, where is the settings page in electron website ?

kirtanchandak avatar Nov 19 '22 19:11 kirtanchandak

@kirtanchandak this is not the repository for the electron website

erickzhao avatar Nov 21 '22 20:11 erickzhao