electron icon indicating copy to clipboard operation
electron copied to clipboard

fix: windows save dialog extension bug

Open nilaoda opened this issue 1 year ago β€’ 1 comments

Description of Change

Fix #44277

Release Notes

Notes: Fix update file extension bug

nilaoda avatar Oct 17 '24 08:10 nilaoda

πŸ’– Thanks for opening this pull request! πŸ’–

Semantic PR titles

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Commit signing

This repo enforces commit signatures for all incoming PRs. To sign your commits, see GitHub's documentation on Telling Git about your signing key.

PR tips

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome[bot] avatar Oct 17 '24 08:10 welcome[bot]

Applying: printing.patch Patch failed at 0025 printing.patch When you have resolved this problem, run "git am --continue".

This win-x64-testing CI failure doesn't seem to have anything do to with this PR. :thinking: I'm not sure how we got here unless main was somehow broken a couple of days ago when this PR was submitted...?

@nilaoda could you please rebase this PR onto electron/electron main to see if that resolves it?

ckerr avatar Oct 20 '24 16:10 ckerr

@ckerr I pulled the main branch directly without making any modifications, and I encountered the same issue when compiling with @electron/build-tools. I don’t believe this is related to my MR.πŸ₯²

Additionally, could you use Squash merge when merging this PR? This would help keep the commit list clean.

nilaoda avatar Oct 21 '24 02:10 nilaoda

@nilaoda can you rebase your PR? that way it'll include a fix for some of the failing tests in CI.

samuelmaddock avatar Nov 04 '24 16:11 samuelmaddock

Congrats on merging your first pull request! πŸŽ‰πŸŽ‰πŸŽ‰

welcome[bot] avatar Nov 20 '24 22:11 welcome[bot]

Release Notes Persisted

Fix update file extension bug

release-clerk[bot] avatar Nov 20 '24 22:11 release-clerk[bot]

I have automatically backported this PR to "34-x-y", please check out #44770

trop[bot] avatar Nov 20 '24 22:11 trop[bot]

I have automatically backported this PR to "33-x-y", please check out #44771

trop[bot] avatar Nov 20 '24 22:11 trop[bot]