build-tools icon indicating copy to clipboard operation
build-tools copied to clipboard

fix: only auto-update main branch

Open samuelmaddock opened this issue 1 year ago • 2 comments

I noticed build-tools pulling down branches which aren't relevant to most users. I've changed auto-update to only pull down main/master.

% e build
Checking for build-tools updates
Running "git pull --rebase --autostash" in /Users/samuelmaddock/.electron_build_tools
From https://github.com/electron/build-tools
   dad2c81..c92af31  debug/ci   -> origin/debug/ci
build-tools is up-to-date

samuelmaddock avatar Dec 06 '23 00:12 samuelmaddock

@samuelmaddock, this repo requires signed commits for merging.

Screenshot 2023-12-10 at 2 26 10 PM

dsanders11 avatar Dec 10 '23 22:12 dsanders11

@samuelmaddock like there are some tests failing with this PR.

At first glance, it looks like it's just that the tests are expecting a specific output & those expectations need to be updated with this new git log message. Could you confirm & update the tests?

ckerr avatar Jan 09 '24 18:01 ckerr

Test failure was fixed by rebasing on main (brought in #543, which fixed the failure). Force pushed to get a signed commit so this can be merged.

dsanders11 avatar Feb 09 '24 22:02 dsanders11