electron-wix-msi

electron-wix-msi copied to clipboard

I think we should be able to use our entire customized UI too. the code below prevents us from creating our own custom dialogs, because it accuses us of duplication...

ezequielvictor

Co-authored-by: Keeley Hammond This change aims to bring icon path config names in line with other `electron-forge` `makers` to improve clarity for users. note that this would be a breaking...

georgexu99

When passing in an updated `exe` value in MakerWixConfig, only the stub exe is uses this Related code: https://github.com/electron-userland/electron-wix-msi/blob/2339d98a765417e7236dbf72340ff1b3e0ade87e/src/creator.ts#L687-L689

kylenakano

https://github.com/electron-userland/electron-wix-msi/blob/2339d98a765417e7236dbf72340ff1b3e0ade87e/src/utils/rc-edit.ts#L22 I think this is a dependencies reference error. I did not find the `exe-icon-extractor` in the package.json, which caused a CI error in electron-forge. 👉 https://github.com/electron/forge/pull/3336

caoxiemeihao

https://github.com/bitdisaster/Squirrel.Msi is not up-to-date with msq.exe used in this module are you using a fork in this repo?

Karmel85

Hi! When configuring electron-wix-msi to work with EV certificate, there's a need to provide `signtool` parameters through `signWithParams` option. Sample `signWithParams` value that works for our token: ``` /f "${process.env.MSI_SIGNTOOL_CERT}"...

kkaimtl

>upgradeCode (string, optional) - A unique UUID used by your app to identify itself. This module will generate one for you, but it is important to reuse it to enable...

Stormpass

The code introduces the exe-icon-extractor package inconsistently with the package.json definition

1

The definition uses the `@bitdisaster/exe-icon-extractor`： https://github.com/electron-userland/electron-wix-msi/blob/master/package.json#L36 The source code uses the `exe-icon-extractor` https://github.com/electron-userland/electron-wix-msi/blob/master/src/utils/rc-edit.ts#L22 When I use `electron-wix-msi` to build a windows application, I get a message that exe-icon-extractor cannot be...

Sallyfafafa

Hi. I have a huge problem and I don't how to deal with it. When I install the app I install it globaly to my disk (not in folder). When...

AnKu9696

I've been trying to get automatic updates working (I set `features.autoUpdate` to `true` and also set `installLevel` to `3` in `forge.config.ts`), and when my app tries to access the update...

chrissygonzalez