electron-webpack icon indicating copy to clipboard operation
electron-webpack copied to clipboard

electron-webpack issue on --env.production parameter

Open channelaffairs opened this issue 4 years ago • 1 comments

  • Version: @expo/electron-adapter": "0.0.55" electron: "13.1.2" electron-builder: "22.11.7"

No electron-updater used

  • Target: Mac, Win and Linux (same issue)
image When attempting to build for Mac/Win/Linux , the electron-webpack somehow does not handle the absence of the --env.production parameter that from my scripts is not even explicitly declared image Commenting the lines in the screenshot solves the problem and allows me to build on all platforms Below the command that I execute to start the build

build-electron: yarn build-deps && yarn electron-webpack && yarn electron-builder -mwl --dir -c.compression=store -c.mac.identity=null The command above follows (as far as I'm aware) the guidelines provided by expo for the correct integration with electron

Thanks Guys!

channelaffairs avatar Jun 22 '21 03:06 channelaffairs

The issue was coming from weback 4.x.x being not compatible with electron-webpack at present time... I wish this stuff was documented guys as I'm sure the more devs will adopt web pack 4 the more this issue will occur

Anyhow for future reference use the following versions of webpack and webpack-cli:

webpack-cli: 3.3.10 webpack: 3.12.0

Gab1988 avatar Jul 27 '21 12:07 Gab1988