electron-remote icon indicating copy to clipboard operation
electron-remote copied to clipboard
verified publisher icon electron-userland

Don't save the response if HTTP response is not OK

Open juturu opened this issue 7 years ago • 6 comments

Issue: If the HTTP response is not 200, file is downloaded with the HTTP response text in it.

Fix: Stopping the file write if the response is not OK.

juturu avatar Mar 26 '18 02:03 juturu

@paulcbetts @zeke @felixrieseberg @MarshallOfSound can you please help review this PR?

juturu avatar Mar 27 '18 16:03 juturu

Hi @juturu! I'm not familiar with this library. Are you able to add a test for this scenario?

zeke avatar Mar 27 '18 16:03 zeke

@zeke there are no existing tests for this part of the module.

juturu avatar Mar 27 '18 17:03 juturu

@CharlieHess @felixrieseberg please help with this.

juturu avatar Mar 29 '18 02:03 juturu

@paulcbetts is the only npm owner. @paulcbetts would you be willing to npm owner add juturu or npx semantic-release-cli setup on this repo?

zeke avatar Mar 29 '18 19:03 zeke

@paulcbetts can you help with this please?

juturu avatar Apr 03 '18 16:04 juturu