electron-compilers icon indicating copy to clipboard operation
electron-compilers copied to clipboard
verified publisher icon electron-userland

Fix sass imports

Open alexstrat opened this issue 8 years ago • 4 comments

  • paths is not a valid option to pass to sass.js (see https://github.com/electron/electron-compilers/pull/55#issuecomment-304724319) -> remove it before passing compilerOptions to sass.js
  • fix import's path resolution

Those 2 fixes worked on my project.

alexstrat avatar Jun 16 '17 21:06 alexstrat

@paulcbetts @saschagehlich do you think you could review these changes?

alexstrat avatar Jun 21 '17 10:06 alexstrat

Sorry man, I'm not responsible for this repository. :(

saschagehlich avatar Jul 03 '17 17:07 saschagehlich

@alexstrat I'm not a contributor here, the paths fix is simple enough, but the second change doesn't seem as obvious to me. Is the current code removing /sass/ from the path, even when it isn't supposed to?

It may be beneficial to have that as a separate request-- but I'm not responsible for this repository, either.

alreece45 avatar Aug 12 '17 13:08 alreece45

This should fix nested imports, right? Trying to load the entirety of bulma gets pretty broken right now, file paths seem broken. @import "node_modules/bulma/bulma" works, @import "sass/utilities/_all" inside of the file doesn't, seemingly because of resolved path issue.

Tenrys avatar May 25 '18 14:05 Tenrys