electron-compilers icon indicating copy to clipboard operation
electron-compilers copied to clipboard

Published 20 hours ago • verified publisher icon electron-userland

Update HTML compiler to use Pug

Open Xinayder opened this issue 8 years ago • 5 comments

The update will allow the compiler to use Pug to compile and render .jade and .pug files.

I'm not sure if I've done it correctly, as I couldn't find a way to test the changes. I think that a PR will be required to reflect these changes on electron-compile.

Xinayder avatar Apr 25 '16 00:04 Xinayder

Why are we using an alpha version?

anaisbetts avatar Apr 25 '16 03:04 anaisbetts

It's the latest version available on npm. When I tried installing the 1.11.0 version npm said it couldn't locate it.

Tag history: https://github.com/pugjs/pug/tags

Xinayder avatar Apr 25 '16 03:04 Xinayder

Hm, it might be better to hold off on this until a final version is released

anaisbetts avatar Apr 25 '16 03:04 anaisbetts

There are also some breaking changes between Jade v1 and Pug v2. It would be better to handle them separated until Jade support can be removed.

Lichtjaeger avatar Oct 17 '16 13:10 Lichtjaeger

It's been over a year now, so I suspect that there should be a straight-forward migration path to dropping jade in favor of pug. What needs to be done? Can I help? Should either this PR or #66 be closed in favor of the other or are they truly distinct?

jacobq avatar Jul 31 '18 20:07 jacobq