electron-builder icon indicating copy to clipboard operation
electron-builder copied to clipboard

fix: support array of publisher names in Azure signing config

Open lidel opened this issue 2 months ago • 2 comments

This PR:

  • updates WindowsAzureSigningConfiguration to accept publisherName as string | Array | null
  • aligns JSON schema to match TypeScript type definition
  • allows specifying multiple publisher names for certificate flexibility across certificate changes
  • no functional changes, implementation already handles arrays via asArray() helper and I've confirmed that in https://github.com/ipfs/ipfs-desktop/pull/3013 where we use this patch to fix our windows release

this change makes the schema match the existing documentation which states "Several names can be provided"

lidel avatar Oct 31 '25 20:10 lidel

🦋 Changeset detected

Latest commit: 25477b379ed17bd0369074949bd853cedfd930d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Major
dmg-builder Major
electron-builder-squirrel-windows Major
electron-builder Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 31 '25 20:10 changeset-bot[bot]

Looks like there's some compiler errors from the logs:

Error: packages/app-builder-lib/src/codeSign/windowsSignAzureManager.ts(99,5): error TS2322: Type 'Promise<string | string[] | null>' is not assignable to type 'Promise<string>'.
  Type 'string | string[] | null' is not assignable to type 'string'.
    Type 'null' is not assignable to type 'string'.
Error: packages/app-builder-lib/src/options/winOptions.ts(136,12): error TS2411: Property 'publisherName' of type 'string | string[] | null' is not assignable to 'string' index type 'string | Nullish'.

mmaietta avatar Nov 04 '25 00:11 mmaietta