electron-builder icon indicating copy to clipboard operation
electron-builder copied to clipboard

Electron/asar version 3.2.18

Open Jonathan-W-Aitken opened this issue 9 months ago • 3 comments

Electron/asar version 3.2.18 pulls a blob version that uses inflight that causes massive memory leaks there is a new version of electron/asar 4.0.0 that fixes this, but app-builder-lib

(this is where the npmjs.com pointed me to)

would it be possible to get the electron/asar dependancy updated to use 4.0.0? as this does not use a inflight

└─┬ [email protected] ├─┬ @electron/[email protected] │ └─┬ [email protected] │ └── [email protected] < -- issue

Thank You.

Jonathan-W-Aitken avatar Jun 16 '25 12:06 Jonathan-W-Aitken

What is currently unclear from this issue, is whether you just read that inflight has a memory leak or if it is actually affecting your use of electron builder. If it is affecting you it would be good to know how and if there is a way to reproduce it.

To answer your question only after the ESM migration and the bump of the minimum supported Node.js version to 22.12.0 (see the multiple massive work-in-progress breaking changes pull requests). Also: https://github.com/electron-userland/electron-builder/issues/9033#issuecomment-2945821577

absidue avatar Jun 16 '25 15:06 absidue

I can build an .app and run it perfectly fine say 20 times or 30 times 40 maybe more maybe less, but then that one time you try to launch it it will just completely crash out, wont load it'll just give you the start screen the little multicoloured spinner appears the whole machine will freeze up, only way to close the app is force quit it from a second monitor as the electron app locks everything down and you cant use any shortcuts at all the whole point of electron. start the app again same thing - restart the machine works fine until it happens again - plus the inflight has been dead for 2 years.

Jonathan-W-Aitken avatar Jun 16 '25 16:06 Jonathan-W-Aitken

As far as I can tell from the source code, electron-builder only uses @electron/asar during the build process and does not bundle it into the app. So if you are having issues while running your app because of @electron/asar you should probably be reporting it to Electron instead.

absidue avatar Jun 16 '25 16:06 absidue

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment, or this will be closed in 30 days.

github-actions[bot] avatar Jul 17 '25 00:07 github-actions[bot]

This issue was closed because it has been stalled for 30 days with no activity.

github-actions[bot] avatar Aug 17 '25 00:08 github-actions[bot]