fix: snapcraft core22 and core24 support [#8548]
Closes #8548
Failing for core24
libpxbackend-1.0.so: cannot open shared object file: No such file or directory
Failed to load module: /home/filipe/snap/insomnia/common/.cache/gio-modules/libgiolibproxy.so
g_module_open() failed for /snap/insomnia/x1/gnome-platform/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-svg.so: librsvg-2.so.2: cannot open shared object file: No such file or directory
/snap/insomnia/x1/gnome-platform/usr/lib/x86_64-linux-gnu/libgtk-3-0/gtk-query-immodules-3.0: error while loading shared libraries: libX11.so.6: cannot open shared object file: No such file or directory
Running sudo ldconfig still brings up failure:
error while loading shared libraries: libX11.so.6: cannot open shared object file: No such file or directory
Not sure how to proceed, if anyone familiar with snapcraft can hop in and help, would be appreciated 🙏
cc @mmaietta
🦋 Changeset detected
Latest commit: 528a06637f9188d2900c2f1b310b9a0ace2b2230
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
| Name | Type |
|---|---|
| app-builder-lib | Patch |
| dmg-builder | Patch |
| electron-builder-squirrel-windows | Patch |
| electron-builder | Patch |
| electron-forge-maker-appimage | Patch |
| electron-forge-maker-nsis-web | Patch |
| electron-forge-maker-nsis | Patch |
| electron-forge-maker-snap | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Deploy Preview for car-park-attendant-cleat-11576 ready!
| Name | Link |
|---|---|
| Latest commit | 528a06637f9188d2900c2f1b310b9a0ace2b2230 |
| Latest deploy log | https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6703b691b4f2490008555a0d |
| Deploy Preview | https://deploy-preview-8549--car-park-attendant-cleat-11576.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thanks for your contribution! We'll also want a new unit test for core24.
You can probably just copy-paste this test and update the snap.base value
https://github.com/electron-userland/electron-builder/blob/fc3a78e4e61f916058fca9b15fc16f076c3fabd1/test/src/linux/snapTest.ts#L314-L330
Why is this considered a major semver bump though? Seems more like a minor or even patch semver for fixing core22 and a new feature for core24 as I don't see any breaking API changes
@mmaietta added a test for base core24 and edited the changeset to something lower than major
@filfreire is this tested yet since it's marked ready for review? If so, please update the PR description accordingly when you have a chance.
@mmaietta at the moment this isn't working.
For example when I compile and link on my local dev environment, and I try to use it to bake a .snap build of Insomnia - I get an error similar to:
libpxbackend-1.0.so: cannot open shared object file: No such file or directory
Failed to load module: /home/filipe/snap/insomnia/common/.cache/gio-modules/libgiolibproxy.so
g_module_open() failed for /snap/insomnia/x1/gnome-platform/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-svg.so: librsvg-2.so.2: cannot open shared object file: No such file or directory
/snap/insomnia/x1/gnome-platform/usr/lib/x86_64-linux-gnu/libgtk-3-0/gtk-query-immodules-3.0: error while loading shared libraries: libX11.so.6: cannot open shared object file: No such file or directory
I suspect similar would happen for any other Electron app - as the electron-builder config in question doesn't have anything out of the ordinary, just points to core24
Not sure yet how to fix it
Hey @filfreire, are you still planning to work on this? If not, can I take it off your hands? I want to push this through as I've been having compatibility issues with core22 recently
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
@esimkowitz feel free to work on this