electron-builder icon indicating copy to clipboard operation
electron-builder copied to clipboard

Allow "compression" parameter for nsis/portable on win32

Open mydevpeeps opened this issue 2 weeks ago • 0 comments

Environment

  • Electron-Builder Version: 24.13.3
  • Node Version: 20.14.0
  • Electron Version: 31.0.1
  • Electron Type (current, beta, nightly): current
  • Electron Updater: 6.2.1
  • Target: NSIS

Details

Currently it is only possible to set compression to store on a "win" target. When building NSIS targets it is not possible to set this in the config as the builder errors out with it being an invalid option.

I think this option will help with development cycles and especially while developers are getting used to all the settings to test.

Testing

I tested hardcoding -mx=0 and -mmt=on inside app-builder-lib's out/targets/archive.js and saw the time it was taking to build my test NSIS build decrease by more than 50%, sometimes 70%. Further the size difference for my basic build was 119MB vs. 123MB so there wasn't much to gain there in my case. I could not get this to do the same with portable.

mydevpeeps avatar Jun 17 '24 15:06 mydevpeeps