electron-builder icon indicating copy to clipboard operation
electron-builder copied to clipboard

Make the NSIS installer require Windows 10 if the Electron version is 23.0.0 or later

Open ItsHarper opened this issue 1 year ago • 5 comments

  • Target: NSIS, NSIS Web

Electron 23 removes support for Windows 7, 8, and 8.1. To prevent users of those operating systems from auto-updating to a version that won't run on their computer, electron-builder should build an NSIS installer that will refuse to run on those systems if the electron version is 23.0.0 or later. See the following code: https://github.com/electron-userland/electron-builder/blob/79df54238621fbe48ba20444129950ba2dc49983/packages/app-builder-lib/templates/nsis/common.nsh#L48-L55

ItsHarper avatar Feb 29 '24 17:02 ItsHarper

While we're at it, we should also reject Windows Server 2012R2 and older.

ItsHarper avatar Feb 29 '24 20:02 ItsHarper

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Jul 13 '24 00:07 github-actions[bot]

This still needs to happen. I've made a patch that works for my purposes, but it's not something that can be upstreamed as-is.

ItsHarper avatar Jul 13 '24 01:07 ItsHarper

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Sep 12 '24 00:09 github-actions[bot]

I don't think this has happened yet

ItsHarper avatar Sep 12 '24 04:09 ItsHarper

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Dec 17 '24 00:12 github-actions[bot]

This issue was closed because it has been stalled for 30 days with no activity.

github-actions[bot] avatar Apr 04 '25 00:04 github-actions[bot]