electron-builder icon indicating copy to clipboard operation
electron-builder copied to clipboard

NSIS - MUI2: include nsh with MUI_PAGE_FINISH - Finish page comes before installation

Open NicoLaval opened this issue 5 months ago • 0 comments

  • Electron-Builder Version: v24.6.4
  • Node Version: v20.9.0
  • Electron Version: V28.1.3
  • Electron Type (current, beta, nightly): current
  • Target: es5
I have the following simple nsh script I include in my build:

!include MUI2.nsh

!insertMacro MUI_PAGE_WELCOME
!insertMacro MUI_PAGE_DIRECTORY
!insertmacro MUI_PAGE_FINISH

The installer display the MUI_PAGE_FINISH before installing, when I press close button installation is made and that's it (installation is even good). I would like to order pages to have Welcome, Directory choice, pressing install and then having finish page.

Even if I had MUI_PAGE_INSTFILES:

!include MUI2.nsh

!insertMacro MUI_PAGE_WELCOME
!insertMacro MUI_PAGE_DIRECTORY
!insertmacro MUI_PAGE_INSTFILES
!insertmacro MUI_PAGE_FINISH

Same behaviour. Any idea?

NicoLaval avatar Jan 16 '24 20:01 NicoLaval