electron-builder icon indicating copy to clipboard operation
electron-builder copied to clipboard

NSIS uninstaller ignores `_?` option to override the installation directory

Open devinbinnie opened this issue 1 year ago • 3 comments

  • Electron-Builder Version: 24.8.4, was able to reproduce at least back to 23.0.3
  • Node Version: v18.12.0
  • Electron Version: 26.2.1
  • Electron Type (current, beta, nightly): current
  • Target: NSIS

As per the NSIS documentation, the uninstaller should support overriding the INSTDIR, but the option doesn't seem to work.

I think it might be similarly related to this bug in which the option needed to be explicitly added to override the INSTDIR that is being specified here: https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/templates/nsis/multiUser.nsh#L43

devinbinnie avatar Oct 24 '23 15:10 devinbinnie

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Mar 19 '24 00:03 github-actions[bot]

Bump

devinbinnie avatar Mar 19 '24 11:03 devinbinnie

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar May 19 '24 00:05 github-actions[bot]

This issue was closed because it has been stalled for 30 days with no activity.

github-actions[bot] avatar Jun 18 '24 00:06 github-actions[bot]