electron-builder icon indicating copy to clipboard operation
electron-builder copied to clipboard

Scope name ends up in application folder name in MSI

Open vincesp opened this issue 8 months ago • 6 comments

  • Electron-Builder Version: 24.6.4
  • Node Version: 18.18.0
  • Electron Version: @27.0.0
  • Electron Type (current, beta, nightly): current
  • Target: Windows, MSI

The name in my package.json file includes a scope:

{
  "name": "@some-scope/my-app"
}

With oneClick = true and perMachine = false, the generated MSI package will install my application in a folder with the following name which looks really ugly:
some-scopemy-app
There seems to be no option to fix that.

writeManifest() calls getWindowsInstallationDirName() here, which in turn defaults to appInfo.sanitizedName here, which uses this.info.metadata.name.

Either omit the scope when computing the sanitizedName, or introduce an option to set the install folder name directly in the config.

vincesp avatar Oct 11 '23 12:10 vincesp

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Dec 11 '23 00:12 github-actions[bot]

Any update on this?

vincesp avatar Dec 11 '23 15:12 vincesp

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Apr 16 '24 00:04 github-actions[bot]

Not stale

vincesp avatar Apr 16 '24 10:04 vincesp