electron-builder icon indicating copy to clipboard operation
electron-builder copied to clipboard

FEAT: Add support for required 'FileSet' files under `extraResources`

Open Nokel81 opened this issue 11 months ago • 9 comments

  • Electron-Builder Version: 23.6.0
  • Node Version: 16.19.0
  • Electron Version: 22.3.5
  • Electron Type (current, beta, nightly): current
  • Target: all

It would be great if the 'FileSet' type used by extraResources and extraFiles could have an optional field required: boolean field (default false) which when set to true would cause the electron-builder invocation to fail with an error.

Nokel81 avatar Jul 12 '23 12:07 Nokel81

This sounds like a great idea, however, I've been trying to figure out how to modify the appFileCopier and related ResolvedFileSet logic for over a year with no success. 😞 Happy to review a PR if you're willing to give it a shot! I'll investigate as well but can't guarantee any timeline for doing so (work is crazy as of late)

mmaietta avatar Jul 28 '23 20:07 mmaietta

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Sep 27 '23 00:09 github-actions[bot]

Yes still interested

Nokel81 avatar Sep 27 '23 10:09 Nokel81

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Dec 17 '23 00:12 github-actions[bot]

Still interested

Nokel81 avatar Dec 17 '23 02:12 Nokel81

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Feb 17 '24 00:02 github-actions[bot]

Not stale

Nokel81 avatar Feb 17 '24 04:02 Nokel81

Happy to review a PR if you're willing to give it a shot!

mmaietta avatar Feb 17 '24 20:02 mmaietta

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Apr 26 '24 00:04 github-actions[bot]