electron-builder icon indicating copy to clipboard operation
electron-builder copied to clipboard

Attempts to sign missing uninstaller

Open joaquimrocha opened this issue 1 year ago • 0 comments

  • Electron-Builder Version: 23.3.3
  • Node Version: v16.15.1
  • Electron Version: 19.0.8
  • Electron Type (current, beta, nightly): current
  • Target: Windows

After assigning the "sign" option for the windows target, the signing fails on ENOENT since the sign script is called against __uninstaller-nsis-headlamp.exe (headlamp is our project).

I am not familiar with the source code, but taking a quick look into the uninstaller signing part, it looks like the uninstaller is only being created under MacOS Catalina.

Again, I don't know enough to understand what's the best approach here, but seems like it should either always create the uninstaller, and/or only sign it if it's been created. Any help or guidance is appreciated.

joaquimrocha avatar Aug 17 '22 14:08 joaquimrocha